Skip to content

Feature 4#53

Closed
Hrusikesh001 wants to merge 2 commits intoAvishkarPatil:mainfrom
Hrusikesh001:feature-4
Closed

Feature 4#53
Hrusikesh001 wants to merge 2 commits intoAvishkarPatil:mainfrom
Hrusikesh001:feature-4

Conversation

@Hrusikesh001
Copy link
Contributor

@Hrusikesh001 Hrusikesh001 commented Sep 4, 2025

🔗 Related Issue

🎯 Rationale

  • Current issue matching was limited and not flexible enough.

  • Users couldn’t filter issues by skills/keywords, making discovery harder.

  • Theme consistency across dark/light mode was inconsistent.

  • This PR improves backend issue retrieval and frontend filtering/UI, creating a smoother developer experience.

📝 Summary of Changes

Backend

  • Added load_model() function for FAISS model and initialized it on app startup.

  • Expanded GitHub search query to include title, body, and comments (beyond labels).

  • Configured session middleware cookie (issuematch_session) with proper attributes.

  • Improved error handling and logging in auth.py and faiss_search.py.

Frontend

  • New Component: IssueFilter – filter issues by user skills and predefined keywords.

  • Integrated IssueFilter into IssuesList with dynamic queries.

  • Improved error state when user is not logged in (shows login prompt).

  • Extended API timeout from 15s → 25s for reliability.

  • Updated styling for skills page, skills test, and welcome screen for consistent dark/light themes.

🔧 Technical Details

  • No new external dependencies added.

  • Refactored FAISS model loading for performance and maintainability.

  • UI uses existing context (useAuth) and Firebase integration.

  • Purely additive frontend feature (IssueFilter) – no breaking changes to existing flows.

✅ Testing

Test Coverage

  • Manual testing completed

  • All existing tests pass

Test Details

  • Verified FAISS model loads on backend startup without errors.

  • Confirmed GitHub issue queries return results with expanded scope.

  • Tested issue filtering with both predefined skills and user skills.

  • Checked UI behavior in both light and dark modes.

  • Validated login-required prompt when accessing issues list unauthenticated.

📚 Documentation

✅ Inline code comments updated

🔄 Breaking Changes

✅ None introduced

🎨 User-Facing Changes

Frontend Changes

  • Added IssueFilter dropdown (skills/keywords).

  • Improved dark/light theme styling across skills pages and test.

  • Updated button, progress bar, and divider animations.

Backend/API Changes

  • None (existing /issues endpoint behavior unchanged, only enhanced internally).

📋 Checklist

✅ Code follows project style guidelines
✅ Self-review completed
✅ No debug statements left
✅ Error handling implemented
✅ PR title and description are descriptive
✅ Commits are atomic and documented
✅Branch is up to date with main

🚀 Deployment Notes

  • No database or config changes needed.
  • Standard deployment flow.

📸 Screenshots/Demo

Screenshot 2025-09-04 193644 Screenshot 2025-09-04 193601

🙏 Reviewer Notes

  • Please pay attention to FAISS model initialization (moved to startup).

  • Review the IssueFilter integration for possible improvements.

  • Styling tweaks tested manually, feedback on theme consistency appreciated.

@AvishkarPatil Could you please review and let me know if it looks good?

Please check and merge the PR

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

Thanks for creating a PR for your Issue! ☺️

We'll review it as soon as possible.
In the meantime, please double-check the file changes and ensure that all commits are accurate.

If there are any unresolved review comments, feel free to resolve them. 🙌🏼

@Hrusikesh001
Copy link
Contributor Author

@AvishkarPatil Please check and merge the PR.

@AvishkarPatil
Copy link
Owner

@Hrusikesh001 The changes look good. It would be better if you move the filter button closer to the "Sort" button and align the UI with the web version.

@Hrusikesh001
Copy link
Contributor Author

@Hrusikesh001 The changes look good. It would be better if you move the filter button closer to the "Sort" button and align the UI with the web version.

Ok I will do it

@Hrusikesh001 Hrusikesh001 mentioned this pull request Sep 7, 2025
@Hrusikesh001
Copy link
Contributor Author

please check the changes and merge the PR. @AvishkarPatil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skill-Based Issue Filtering

3 participants